third_party/WebKit/Source/core/loader/ImageLoader.cpp - Issue 2839633003: Consider empty url case when loading image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.cpp

Issue 2839633003: Consider empty url case when loading image (Closed)

Patch Set: added unit test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/ImageLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.cpp b/third_party/WebKit/Source/core/loader/ImageLoader.cpp

index fd04befc8bacbc2a73a180daef58970be00342f1..17af95217b842bb59604a399fdd586c449918487 100644

--- a/third_party/WebKit/Source/core/loader/ImageLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/ImageLoader.cpp

@@ -291,7 +291,7 @@ void ImageLoader::DoUpdateFromElement(BypassMainWorldBehavior bypass_behavior,

AtomicString image_source_url = element_->ImageSourceURL();

ImageResourceContent* new_image = nullptr;

- if (!url.IsNull()) {

+ if (!url.IsNull() && !url.IsEmpty()) {

// Unlike raw <img>, we block mixed content inside of <picture> or

// <img srcset>.

ResourceLoaderOptions resource_loader_options =