Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: build/common.gypi

Issue 283963002: Android: bake GCC flags for perf into profiling=1 in GYP_DEFINES (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: vague comment added Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 23ea72721deacaf04a837ab34ffd401e8be2e224..fc976959c1b16a226e99e3eefff13f2fb5657bbe 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3447,8 +3447,16 @@
}],
['profiling==1', {
'cflags': [
- '-marm', # Probably reduntant, but recommend by "perf" docs.
- '-mapcs-frame', # Seems required by -fno-omit-frame-pointer.
+ # Thumb code with frame pointer makes chrome crash
+ # early.
+ '-marm',
+ '-mapcs-frame', # Required by -fno-omit-frame-pointer.
+ # The perf report sometimes incorrectly attributes
+ # code from tail calls.
+ '-fno-optimize-sibling-calls',
+ ],
+ 'cflags!': [
+ '-fomit-frame-pointer',
],
}],
['clang==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698