Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

Issue 2839563002: [ES6 modules] Return previous error when an instantiation is reattempt. (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
diff --git a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
index e5fb1fae307ede3751cffe7f20d2cd204a5768b1..1be380b8d57a264c77d25c62d1e19d651ed195c2 100644
--- a/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
+++ b/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp
@@ -140,6 +140,14 @@ ScriptValue ModulatorImpl::InstantiateModule(ScriptModule script_module) {
return script_module.Instantiate(script_state_.Get());
}
+ScriptValue ModulatorImpl::GetInstantiationError(
+ const ModuleScript* module_script) {
+ ScriptState::Scope scope(script_state_.Get());
+ return ScriptValue(script_state_.Get(),
+ module_script->CreateInstantiationErrorInternal(
+ script_state_->GetIsolate()));
+}
+
Vector<String> ModulatorImpl::ModuleRequestsFromScriptModule(
ScriptModule script_module) {
ScriptState::Scope scope(script_state_.Get());
@@ -176,7 +184,8 @@ void ModulatorImpl::ExecuteModule(const ModuleScript* module_script) {
if (instantiationState == ModuleInstantiationState::kErrored) {
v8::Isolate* isolate = script_state_->GetIsolate();
ScriptModule::ReportException(
- script_state_.Get(), module_script->CreateInstantiationError(isolate),
+ script_state_.Get(),
+ module_script->CreateInstantiationErrorInternal(isolate),
module_script->BaseURL().GetString());
return;
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/ModulatorImpl.h ('k') | third_party/WebKit/Source/core/dom/ModuleScript.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698