third_party/WebKit/Source/core/testing/DummyModulator.cpp - Issue 2839563002: [ES6 modules] Return previous error when an instantiation is reattempt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyModulator.cpp

Issue 2839563002: [ES6 modules] Return previous error when an instantiation is reattempt. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DummyModulator.cpp

diff --git a/third_party/WebKit/Source/core/testing/DummyModulator.cpp b/third_party/WebKit/Source/core/testing/DummyModulator.cpp

index 3fbc977ed10e477b84154b0ab6b107c58c497397..c598efacd72b34cedebabdf3d5b84c16f14646d9 100644

--- a/third_party/WebKit/Source/core/testing/DummyModulator.cpp

+++ b/third_party/WebKit/Source/core/testing/DummyModulator.cpp

@@ -77,6 +77,11 @@ ScriptValue DummyModulator::InstantiateModule(ScriptModule) {

return ScriptValue();

}

+ScriptValue DummyModulator::GetInstantiationError(const ModuleScript*) {

+ NOTREACHED();

+ return ScriptValue();

Vector<String> DummyModulator::ModuleRequestsFromScriptModule(ScriptModule) {

NOTREACHED();

return Vector<String>();