Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2480)

Unified Diff: components/translate/core/browser/ranker_model_loader_unittest.cc

Issue 2839433002: [translate] Fix shutdown race for translate ranker model loader. (Closed)
Patch Set: fdoray part deux Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/ranker_model_loader_unittest.cc
diff --git a/components/translate/core/browser/ranker_model_loader_unittest.cc b/components/translate/core/browser/ranker_model_loader_unittest.cc
index 9a8be0091538880c825036a2ea676aa458b988ed..c312c2d09f4d9ec49749cf6bd3a96bf862b32902 100644
--- a/components/translate/core/browser/ranker_model_loader_unittest.cc
+++ b/components/translate/core/browser/ranker_model_loader_unittest.cc
@@ -12,6 +12,7 @@
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/ptr_util.h"
+#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
@@ -199,8 +200,7 @@ bool RankerModelLoaderTest::DoLoaderTest(const base::FilePath& model_path,
base::Bind(&RankerModelLoaderTest::OnModelAvailable,
base::Unretained(this)),
model_path, model_url, "RankerModelLoaderTest");
-
- loader->Start();
+ loader->NotifyOfRankerActivity();
base::RunLoop().RunUntilIdle();
return true;

Powered by Google App Engine
This is Rietveld 408576698