[translate] Fix shutdown race for translate ranker model loader.

components/translate/core/browser/translate_url_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_url_fetcher.h"
 
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
@@ skipping 28 matching lines @@
   }
 
   if (retry_count_ >= kMaxRetry)
     return false;
   retry_count_++;
 
   state_ = REQUESTING;
   url_ = url;
   callback_ = callback;
 
+  // If the TranslateDownloadManager's request context getter is nullptr then
+  // shutdown is in progress. Abort the request, which can't proceed with a
+  // null request_context_getter.
+  net::URLRequestContextGetter* request_context_getter =
+      TranslateDownloadManager::GetInstance()->request_context();

[groby-ooo-7-16, 2017/04/24 19:12:46]

So, request_context is RefCountedThreadSafe. Should we maybe return a
scoped_refptr? Or at least take the parameter into a scoped_refptr?

[Roger McFarlane (Chromium), 2017/04/24 20:31:34]

I put the returned value in to a scoped_refptr.

It's a bit unfortunate that the getter and setter take raw pointer values. But I
suspect it might be because taking and returning scoped_refptr<T> by value
requires that the full definition of T be available, which means you can't just
forward declare T.

I'm not averse to changing it to accept/return scoped_refptr instead, but that's
probably be better done in its own CL.

+  if (request_context_getter == nullptr)
+    return false;
+
+  // Create and initialize the URL fetcher.
   fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
-  fetcher_->SetRequestContext(
-      TranslateDownloadManager::GetInstance()->request_context());
+  fetcher_->SetRequestContext(request_context_getter);
+
   // Set retry parameter for HTTP status code 5xx. This doesn't work against
   // 106 (net::ERR_INTERNET_DISCONNECTED) and so on.
   // TranslateLanguageList handles network status, and implements retry.
   fetcher_->SetMaxRetriesOn5xx(max_retry_on_5xx_);
   if (!extra_request_header_.empty())
     fetcher_->SetExtraRequestHeaders(extra_request_header_);
 
   fetcher_->Start();
 
   return true;
@@ skipping 10 matching lines @@
   } else {
     state_ = FAILED;
   }
 
   // Transfer URLFetcher's ownership before invoking a callback.
   std::unique_ptr<const net::URLFetcher> delete_ptr(fetcher_.release());
   callback_.Run(id_, state_ == COMPLETED, data);
 }
 
 }  // namespace translate