Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Settings.js

Issue 2839413002: DevTools: add rendering overlay options to command menu (Closed)
Patch Set: ac Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/common/Settings.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Settings.js b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
index 280e168499ef29428b2a15c9190a0eabe04baea1..26b9e7123a1c31a88b3467a561cf74b1d121d346 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Settings.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Settings.js
@@ -75,6 +75,7 @@ Common.Settings = class {
this.createSetting(settingName, defaultValue, storageType);
if (descriptor['title'])
setting.setTitle(descriptor['title']);
+ setting.setExtension(extension);
this._moduleSettings.set(settingName, setting);
}
@@ -263,6 +264,7 @@ Common.Setting = class {
this._storage = storage;
/** @type {string} */
this._title = '';
+ this._extension = null;
}
/**
@@ -342,6 +344,20 @@ Common.Setting = class {
}
/**
+ * @return {?Runtime.Extension}
+ */
+ extension() {
+ return this._extension;
+ }
+
+ /**
+ * @param {!Runtime.Extension} extension
+ */
+ setExtension(extension) {
dgozman 2017/05/16 18:47:25 Remove this setter, and assign directly above. We
luoe 2017/05/30 20:56:14 Done.
+ this._extension = extension;
+ }
+
+ /**
* @param {string} message
* @param {string} name
* @param {string} value

Powered by Google App Engine
This is Rietveld 408576698