DevTools: add rendering overlay options to command menu

third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 128 matching lines @@
  */
 Settings.GenericSettingsTab = class extends Settings.SettingsTab {
   constructor() {
     super(Common.UIString('Preferences'), 'preferences-tab-content');
 
     /** @const */
     var explicitSectionOrder =
         ['', 'Appearance', 'Elements', 'Sources', 'Network', 'Profiler', 'Console', 'Extensions'];
     /** @type {!Map<string, !Element>} */
     this._nameToSection = new Map();
-    /** @type {!Map<string, !Element>} */
-    this._nameToSettingElement = new Map();
     for (var sectionName of explicitSectionOrder)
       this._sectionElement(sectionName);
     self.runtime.extensions('setting').forEach(this._addSetting.bind(this));
     self.runtime.extensions(UI.SettingUI).forEach(this._addSettingUI.bind(this));
 
     this._appendSection().appendChild(
         UI.createTextButton(Common.UIString('Restore defaults and reload'), restoreAndReload));
 
     function restoreAndReload() {
       Common.settings.clearAll();
@@ skipping 13 matching lines @@
       return false;
     return true;
   }
 
   /**
    * @param {!Runtime.Extension} extension
    */
   _addSetting(extension) {
     if (!Settings.GenericSettingsTab.isSettingVisible(extension))
       return;
-    var descriptor = extension.descriptor();
-    var sectionName = descriptor['category'];
-    var settingName = descriptor['settingName'];
-    var setting = Common.moduleSetting(settingName);
-    var uiTitle = Common.UIString(extension.title());
-
-    var sectionElement = this._sectionElement(sectionName);
-    var settingControl;
-
-    switch (descriptor['settingType']) {
-      case 'boolean':
-        settingControl = UI.SettingsUI.createSettingCheckbox(uiTitle, setting);
-        break;
-      case 'enum':
-        if (Array.isArray(descriptor['options']))
-          settingControl = UI.SettingsUI.createSettingSelect(uiTitle, descriptor['options'], setting);
-        else
-          console.error('Enum setting defined without options');
-        break;
-      default:
-        console.error('Invalid setting type: ' + descriptor['settingType']);
-        return;
-    }
-    if (settingControl) {
-      this._nameToSettingElement.set(settingName, settingControl);
+    var sectionElement = this._sectionElement(extension.descriptor()['category']);
+    var setting = Common.moduleSetting(extension.descriptor()['settingName']);
+    var settingControl = UI.SettingsUI.createControlForSetting(setting);
+    if (settingControl)
       sectionElement.appendChild(settingControl);
-    }
   }
 
   /**
    * @param {!Runtime.Extension} extension
    */
   _addSettingUI(extension) {
     var descriptor = extension.descriptor();
     var sectionName = descriptor['category'] || '';
     extension.instance().then(appendCustomSetting.bind(this));
 
@@ skipping 151 matching lines @@
         return;
       var settings = extension.descriptor()['settings'];
       if (settings && settings.indexOf(setting.name) !== -1) {
         InspectorFrontendHost.bringToFront();
         Settings.SettingsScreen._showSettingsScreen(extension.descriptor()['id']);
         success = true;
       }
     }
   }
 };