DevTools: add rendering overlay options to command menu

third_party/WebKit/Source/devtools/front_end/common/Settings.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 57 matching lines @@
       case ('global'):
         storageType = Common.SettingStorageType.Global;
         break;
       default:
         storageType = Common.SettingStorageType.Global;
     }
     var setting = isRegex ? this.createRegExpSetting(settingName, defaultValue, undefined, storageType) :
                             this.createSetting(settingName, defaultValue, storageType);
     if (descriptor['title'])
       setting.setTitle(descriptor['title']);
+    setting.setExtension(extension);
     this._moduleSettings.set(settingName, setting);
   }
 
   /**
    * @param {string} settingName
    * @return {!Common.Setting}
    */
   moduleSetting(settingName) {
     var setting = this._moduleSettings.get(settingName);
     if (!setting)
@@ skipping 168 matching lines @@
    * @param {!Common.SettingsStorage} storage
    */
   constructor(settings, name, defaultValue, eventSupport, storage) {
     this._settings = settings;
     this._name = name;
     this._defaultValue = defaultValue;
     this._eventSupport = eventSupport;
     this._storage = storage;
     /** @type {string} */
     this._title = '';
+    this._extension = null;
   }
 
   /**
    * @param {function(!Common.Event)} listener
    * @param {!Object=} thisObject
    */
   addChangeListener(listener, thisObject) {
     this._eventSupport.addEventListener(this._name, listener, thisObject);
   }
 
@@ skipping 59 matching lines @@
     this._eventSupport.dispatchEventToListeners(this._name, value);
   }
 
   remove() {
     this._settings._registry.delete(this._name);
     this._settings._moduleSettings.delete(this._name);
     this._storage.remove(this._name);
   }
 
   /**
+   * @return {?Runtime.Extension}
+   */
+  extension() {
+    return this._extension;
+  }
+
+  /**
+   * @param {!Runtime.Extension} extension
+   */
+  setExtension(extension) {

[dgozman, 2017/05/16 18:47:25]

Remove this setter, and assign directly above. We don't want someone to set
extension outside of Settings.js.

setting._extension = extension;

[luoe, 2017/05/30 20:56:14]

Done.

+    this._extension = extension;
+  }
+
+  /**
    * @param {string} message
    * @param {string} name
    * @param {string} value
    */
   _printSettingsSavingError(message, name, value) {
     var errorMessage =
         'Error saving setting with name: ' + this._name + ', value length: ' + value.length + '. Error: ' + message;
     console.error(errorMessage);
     Common.console.error(errorMessage);
     this._storage._dumpSizes();
@@ skipping 467 matching lines @@
   return Common.settings.moduleSetting(settingName);
 };
 
 /**
  * @param {string} settingName
  * @return {!Common.Setting}
  */
 Common.settingForTest = function(settingName) {
   return Common.settings.settingForTest(settingName);
 };