DevTools: add rendering overlay options to command menu

third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 121 matching lines @@
   fieldset.disabled = !setting.get();
   setting.addChangeListener(settingChanged);
   return fieldset;
 
   function settingChanged() {
     fieldset.disabled = !setting.get();
   }
 };
 
 /**
+ * @param {!Runtime.Extension} extension
+ * @return {?Element}
+ */
+UI.SettingsUI.settingExtensionToControl = function(extension) {

[dgozman, 2017/05/15 19:07:44]

Let's pass setting instance here, and let it have extension() getter.

[luoe, 2017/05/16 00:05:47]

Done.

Introducing an extension() getter feels a little strange to me.  It solves the
problem and we only pass Settings around.  However, some Settings made by
createSetting() will not have an extension, and it isn't clear that one UI
property 'title' is accessible on a Setting while another 'Options' is only
accessible on the extension.

`setting.title()`
`setting.extension().descriptor()['options']`

Perhaps it's better to remove `.title()` or introduce `setting.options()`?

[dgozman, 2017/05/16 18:47:25]

I think removing setting.title() is the right way. Thanks for bringing that up!
Let's follow up.

+  var descriptor = extension.descriptor();
+  var setting = Common.moduleSetting(descriptor['settingName']);
+  var uiTitle = Common.UIString(extension.title() || '');
+  switch (descriptor['settingType']) {
+    case 'boolean':
+      return UI.SettingsUI.createSettingCheckbox(uiTitle, setting);
+    case 'enum':
+      return UI.SettingsUI.createSettingSelect(uiTitle, descriptor['options'], setting);

[dgozman, 2017/05/15 19:07:44]

Let's do some validation here - that options exist, etc.

[luoe, 2017/05/16 00:05:47]

Done in the previous patch, since it falls within scope of generalizing
UI-building.

+    default:
+      console.error('Invalid setting type: ' + descriptor['settingType']);
+      return null;
+  }
+};
+
+/**
  * @interface
  */
 UI.SettingUI = function() {};
 
 UI.SettingUI.prototype = {
   /**
    * @return {?Element}
    */
   settingElement() {}
 };