Issue 2839403004: change fasta.Token.isIdentifier() from method to getter

Issue 2839403004: change fasta.Token.isIdentifier() from method to getter (Closed)

Created:
3 years, 7 months ago by danrubel

Modified:
3 years, 6 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -29 lines)			Patch
M	pkg/compiler/lib/src/native/resolver.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View	20 chunks	+22 lines, -22 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/error_token.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/scanner/token.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

danrubel

Change isIdentifier() --> isIdentifier (a getter) so that it matches all of the other is* ...

3 years, 7 months ago (2017-04-27 21:27:36 UTC) #2

danrubel

Committed patchset #1 (id:1) manually as dc19d42c547ab759df4c081e97b0ed5c20e4e8e1 (presubmit successful).

3 years, 7 months ago (2017-04-27 21:39:00 UTC) #5

Message was sent while issue was closed.

lgtm

Nice! But it did cause me some merge problems :-)