struct UnloadedExtensionInfo -> enum UnloadedExtensionInfoReason

extensions/common/extension.h

Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index 704b7dde823184203b50df09d4738ab889d00842..843499c698bac583452aa35ddac7809c34bad4d0 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -519,27 +519,18 @@ struct InstalledExtensionInfo {
                          const std::string& old_name);
 };
 
-struct UnloadedExtensionInfo {
-  // TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
-  enum Reason {
-    REASON_UNDEFINED,         // Undefined state used to initialize variables.
-    REASON_DISABLE,           // Extension is being disabled.
-    REASON_UPDATE,            // Extension is being updated to a newer version.
-    REASON_UNINSTALL,         // Extension is being uninstalled.
-    REASON_TERMINATE,         // Extension has terminated.
-    REASON_BLACKLIST,         // Extension has been blacklisted.
-    REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
-    REASON_LOCK_ALL,          // All extensions for the profile are blocked.
-    REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
-                                   // action.
-  };
-
-  Reason reason;
-
-  // The extension being unloaded - this should always be non-NULL.
-  const Extension* extension;
-
-  UnloadedExtensionInfo(const Extension* extension, Reason reason);
+// TODO(DHNishi): Move this enum to ExtensionRegistryObserver.
+enum class UnloadedExtensionReason {
+  REASON_UNDEFINED,         // Undefined state used to initialize variables.

[limasdf, 2017/05/02 07:52:52]

devlin@, can I remove this in this CL? I think we always should specify the
exact reason when unloading extension.

[Devlin, 2017/05/02 20:49:27]

Sounds good to me!

[limasdf, 2017/05/03 04:04:55]

I'll not remove it since it is being used from
extension_service_test_with_install.cc

+  REASON_DISABLE,           // Extension is being disabled.
+  REASON_UPDATE,            // Extension is being updated to a newer version.
+  REASON_UNINSTALL,         // Extension is being uninstalled.
+  REASON_TERMINATE,         // Extension has terminated.
+  REASON_BLACKLIST,         // Extension has been blacklisted.
+  REASON_PROFILE_SHUTDOWN,  // Profile is being shut down.
+  REASON_LOCK_ALL,          // All extensions for the profile are blocked.
+  REASON_MIGRATED_TO_COMPONENT,  // Extension is being migrated to a component
+                                 // action.
 };
 
 // The details sent for EXTENSION_PERMISSIONS_UPDATED notifications.