Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: extensions/browser/api/idle/idle_api_unittest.cc

Issue 2839373003: struct UnloadedExtensionInfo -> enum UnloadedExtensionInfoReason (Closed)
Patch Set: Enum class Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/idle/idle_api.h" 5 #include "extensions/browser/api/idle/idle_api.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 idle_provider_->set_idle_time(16); 492 idle_provider_->set_idle_time(16);
493 EXPECT_CALL(*event_delegate_, 493 EXPECT_CALL(*event_delegate_,
494 OnStateChanged(extension()->id(), ui::IDLE_STATE_IDLE)); 494 OnStateChanged(extension()->id(), ui::IDLE_STATE_IDLE));
495 idle_manager_->UpdateIdleState(); 495 idle_manager_->UpdateIdleState();
496 testing::Mock::VerifyAndClearExpectations(event_delegate_); 496 testing::Mock::VerifyAndClearExpectations(event_delegate_);
497 } 497 }
498 498
499 // Threshold will reset after unload (and listen count == 0) 499 // Threshold will reset after unload (and listen count == 0)
500 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context()); 500 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
501 registry->TriggerOnUnloaded(extension(), 501 registry->TriggerOnUnloaded(extension(),
502 UnloadedExtensionInfo::REASON_UNINSTALL); 502 UnloadedExtensionReason::REASON_UNINSTALL);
503 503
504 { 504 {
505 ScopedListen listen(idle_manager_, extension()->id()); 505 ScopedListen listen(idle_manager_, extension()->id());
506 idle_manager_->UpdateIdleState(); 506 idle_manager_->UpdateIdleState();
507 testing::Mock::VerifyAndClearExpectations(event_delegate_); 507 testing::Mock::VerifyAndClearExpectations(event_delegate_);
508 508
509 idle_provider_->set_idle_time(61); 509 idle_provider_->set_idle_time(61);
510 EXPECT_CALL(*event_delegate_, 510 EXPECT_CALL(*event_delegate_,
511 OnStateChanged(extension()->id(), ui::IDLE_STATE_IDLE)); 511 OnStateChanged(extension()->id(), ui::IDLE_STATE_IDLE));
512 idle_manager_->UpdateIdleState(); 512 idle_manager_->UpdateIdleState();
513 } 513 }
514 } 514 }
515 515
516 // Verifies that unloading an extension with no listeners or threshold works. 516 // Verifies that unloading an extension with no listeners or threshold works.
517 TEST_F(IdleTest, UnloadOnly) { 517 TEST_F(IdleTest, UnloadOnly) {
518 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context()); 518 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
519 registry->TriggerOnUnloaded(extension(), 519 registry->TriggerOnUnloaded(extension(),
520 UnloadedExtensionInfo::REASON_UNINSTALL); 520 UnloadedExtensionReason::REASON_UNINSTALL);
521 } 521 }
522 522
523 // Verifies that its ok for the unload notification to happen before all the 523 // Verifies that its ok for the unload notification to happen before all the
524 // listener removals. 524 // listener removals.
525 TEST_F(IdleTest, UnloadWhileListening) { 525 TEST_F(IdleTest, UnloadWhileListening) {
526 ScopedListen listen(idle_manager_, extension()->id()); 526 ScopedListen listen(idle_manager_, extension()->id());
527 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context()); 527 ExtensionRegistry* registry = ExtensionRegistry::Get(browser_context());
528 registry->TriggerOnUnloaded(extension(), 528 registry->TriggerOnUnloaded(extension(),
529 UnloadedExtensionInfo::REASON_UNINSTALL); 529 UnloadedExtensionReason::REASON_UNINSTALL);
530 } 530 }
531 531
532 // Verifies that re-adding a listener after a state change doesn't immediately 532 // Verifies that re-adding a listener after a state change doesn't immediately
533 // fire a change event. Regression test for http://crbug.com/366580. 533 // fire a change event. Regression test for http://crbug.com/366580.
534 TEST_F(IdleTest, ReAddListener) { 534 TEST_F(IdleTest, ReAddListener) {
535 idle_provider_->set_locked(false); 535 idle_provider_->set_locked(false);
536 536
537 { 537 {
538 // Fire idle event. 538 // Fire idle event.
539 ScopedListen listen(idle_manager_, "test"); 539 ScopedListen listen(idle_manager_, "test");
540 idle_provider_->set_idle_time(60); 540 idle_provider_->set_idle_time(60);
541 EXPECT_CALL(*event_delegate_, OnStateChanged("test", ui::IDLE_STATE_IDLE)); 541 EXPECT_CALL(*event_delegate_, OnStateChanged("test", ui::IDLE_STATE_IDLE));
542 idle_manager_->UpdateIdleState(); 542 idle_manager_->UpdateIdleState();
543 testing::Mock::VerifyAndClearExpectations(event_delegate_); 543 testing::Mock::VerifyAndClearExpectations(event_delegate_);
544 } 544 }
545 545
546 // Trigger active. 546 // Trigger active.
547 idle_provider_->set_idle_time(0); 547 idle_provider_->set_idle_time(0);
548 idle_manager_->UpdateIdleState(); 548 idle_manager_->UpdateIdleState();
549 549
550 { 550 {
551 // Nothing should have fired, the listener wasn't added until afterward. 551 // Nothing should have fired, the listener wasn't added until afterward.
552 ScopedListen listen(idle_manager_, "test"); 552 ScopedListen listen(idle_manager_, "test");
553 idle_manager_->UpdateIdleState(); 553 idle_manager_->UpdateIdleState();
554 testing::Mock::VerifyAndClearExpectations(event_delegate_); 554 testing::Mock::VerifyAndClearExpectations(event_delegate_);
555 } 555 }
556 } 556 }
557 557
558 } // namespace extensions 558 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698