base/task_scheduler/task_tracker_unittest.cc - Issue 2839333002: Record the TaskLatency Histogram in Microseconds Instead of Milliseconds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/task_tracker_unittest.cc

Issue 2839333002: Record the TaskLatency Histogram in Microseconds Instead of Milliseconds (Closed)

Patch Set: CR Feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/task_scheduler/task_tracker_unittest.cc

diff --git a/base/task_scheduler/task_tracker_unittest.cc b/base/task_scheduler/task_tracker_unittest.cc

index e1596f7b51fdb3d5df92f687c14656b5dbd398ff..96bda677649f219e02c3f06ec08431bc80490a08 100644

--- a/base/task_scheduler/task_tracker_unittest.cc

+++ b/base/task_scheduler/task_tracker_unittest.cc

@@ -913,29 +913,33 @@ TEST(TaskSchedulerTaskTrackerHistogramTest, TaskLatency) {

const char* const expected_histogram;

} tests[] = {

{TaskTraits().WithPriority(TaskPriority::BACKGROUND),

- "TaskScheduler.TaskLatency.BackgroundTaskPriority"},

+ "TaskScheduler.TaskLatencyMicroseconds.BackgroundTaskPriority"},

{TaskTraits().WithPriority(TaskPriority::BACKGROUND).MayBlock(),

- "TaskScheduler.TaskLatency.BackgroundTaskPriority.MayBlock"},

+ "TaskScheduler.TaskLatencyMicroseconds.BackgroundTaskPriority.MayBlock"},

{TaskTraits()

.WithPriority(TaskPriority::BACKGROUND)

.WithBaseSyncPrimitives(),

- "TaskScheduler.TaskLatency.BackgroundTaskPriority.MayBlock"},

+ "TaskScheduler.TaskLatencyMicroseconds.BackgroundTaskPriority.MayBlock"},

{TaskTraits().WithPriority(TaskPriority::USER_VISIBLE),

- "TaskScheduler.TaskLatency.UserVisibleTaskPriority"},

+ "TaskScheduler.TaskLatencyMicroseconds.UserVisibleTaskPriority"},

{TaskTraits().WithPriority(TaskPriority::USER_VISIBLE).MayBlock(),

- "TaskScheduler.TaskLatency.UserVisibleTaskPriority.MayBlock"},

+ "TaskScheduler.TaskLatencyMicroseconds.UserVisibleTaskPriority."

+ "MayBlock"},

{TaskTraits()

.WithPriority(TaskPriority::USER_VISIBLE)

.WithBaseSyncPrimitives(),

- "TaskScheduler.TaskLatency.UserVisibleTaskPriority.MayBlock"},

+ "TaskScheduler.TaskLatencyMicroseconds.UserVisibleTaskPriority."

+ "MayBlock"},

{TaskTraits().WithPriority(TaskPriority::USER_BLOCKING),

- "TaskScheduler.TaskLatency.UserBlockingTaskPriority"},

+ "TaskScheduler.TaskLatencyMicroseconds.UserBlockingTaskPriority"},

{TaskTraits().WithPriority(TaskPriority::USER_BLOCKING).MayBlock(),

- "TaskScheduler.TaskLatency.UserBlockingTaskPriority.MayBlock"},

+ "TaskScheduler.TaskLatencyMicroseconds.UserBlockingTaskPriority."

+ "MayBlock"},

{TaskTraits()

.WithPriority(TaskPriority::USER_BLOCKING)

.WithBaseSyncPrimitives(),

- "TaskScheduler.TaskLatency.UserBlockingTaskPriority.MayBlock"}};

+ "TaskScheduler.TaskLatencyMicroseconds.UserBlockingTaskPriority."

+ "MayBlock"}};

for (const auto& test : tests) {

auto task =

« no previous file with comments | « base/task_scheduler/task_tracker.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »