Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/module.json

Issue 2839273003: [Devtools] New structure and colorize rows for network products (Closed)
Patch Set: changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/network/module.json b/third_party/WebKit/Source/devtools/front_end/network/module.json
index d8b62a3669d13e2d38b30aa141d83be26a4be2dc..6827c7085b1e114c40f8ddfc7cf502a03f9f5fa8 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/network/module.json
@@ -92,6 +92,20 @@
"order": 40,
"className": "Network.NetworkConfigView",
"tags": "disk cache, network throttling, useragent, user agent"
+ },
+ {
+ "type": "@Network.GroupLookupInterface",
pfeldman 2017/04/27 22:20:49 Don't use dependency injection when you depends on
allada 2017/04/28 01:20:07 These are extensions, it is only used to handle th
pfeldman 2017/04/28 21:08:35 I want you to instantiate them via new instead of
+ "className": "Network.ProductGrouper",
+ "experiment": "networkGroupingRequests",
+ "title": "Product",
+ "id": "product"
+ },
+ {
+ "type": "@Network.GroupLookupInterface",
+ "className": "Network.FrameGrouper",
+ "experiment": "networkGroupingRequests",
+ "title": "Frame",
+ "id": "frame"
}
],
"dependencies": [
@@ -102,7 +116,8 @@
"data_grid",
"network_conditions",
"object_ui",
- "network_log"
+ "network_log",
+ "product_registry"
],
"scripts": [
"BlockedURLsPane.js",
@@ -117,6 +132,7 @@
"NetworkTimeCalculator.js",
"NetworkLogView.js",
"NetworkLogViewColumns.js",
+ "NetworkGroupers.js",
"NetworkManageCustomHeadersView.js",
"NetworkOverview.js",
"NetworkWaterfallColumn.js",

Powered by Google App Engine
This is Rietveld 408576698