Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 2839193003: Rename TypeInferrerImpl._context to _closureContext; make `null` outside of closures. (Closed)

Created:
3 years, 8 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename TypeInferrerImpl._context to _closureContext; make `null` outside of closures. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d30c7e765084ffed0a8fe7ea43c5820c94d16763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M pkg/front_end/front_end.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 4 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 8 months ago (2017-04-26 16:32:52 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-26 16:34:13 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as d30c7e765084ffed0a8fe7ea43c5820c94d16763 (presubmit successful).
3 years, 8 months ago (2017-04-26 18:40:12 UTC) #5
ahe
3 years, 7 months ago (2017-04-27 10:41:08 UTC) #6
Message was sent while issue was closed.
lgtm

That's an elegant solution.

Powered by Google App Engine
This is Rietveld 408576698