Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: ios/web_view/shell/shell_view_controller.m

Issue 2839093002: Implemented new Translate API for purely Objective-C clients. (Closed)
Patch Set: Added some error handling. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/shell/shell_view_controller.m
diff --git a/ios/web_view/shell/shell_view_controller.m b/ios/web_view/shell/shell_view_controller.m
index c7b1b2a059774c8636317fa655ca9ca23b22540f..3517766a9e0679cec7ede25cd5e73eb96f7becb1 100644
--- a/ios/web_view/shell/shell_view_controller.m
+++ b/ios/web_view/shell/shell_view_controller.m
@@ -156,7 +156,7 @@ NSString* const kWebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier =
_webView.navigationDelegate = self;
_webView.UIDelegate = self;
_translateController = [[TranslateController alloc] init];
Hiroshi Ichikawa 2017/04/26 08:40:57 Can you maybe rename this class and the variable n
jzw1 2017/04/27 04:54:02 Done.
- _webView.translationDelegate = _translateController;
+ _webView.translationController.delegate = _translateController;
[_webView setAutoresizingMask:UIViewAutoresizingFlexibleWidth |
UIViewAutoresizingFlexibleHeight];

Powered by Google App Engine
This is Rietveld 408576698