ios/web_view/public/cwv_translation_language.h - Issue 2839093002: Implemented new Translate API for purely Objective-C clients.

Side by Side Diff: ios/web_view/public/cwv_translation_language.h

Issue 2839093002: Implemented new Translate API for purely Objective-C clients. (Closed)

Patch Set: Added some error handling. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ios/web_view/public/cwv_translation_controller.h ('K') | « ios/web_view/public/cwv_translation_controller.h ('k') | ios/web_view/public/cwv_web_view.h » ('j') | ios/web_view/shell/shell_view_controller.m » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_LANGUAGE_H

	6 #define IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_LANGUAGE_H

	7

	8 #import <ChromeWebView/cwv_export.h>

	9 #import <Foundation/Foundation.h>

	10

	11 // Represents a single translatable language.

	12 CWV_EXPORT

	13 @interface CWVTranslationLanguage : NSObject

	14

	15 - (instancetype)init NS_UNAVAILABLE;

	16

	17 // The ISO language code. en for English, es for Spanish, etc...
	Hiroshi Ichikawa 2017/04/26 08:40:57 Can you add a link to https://cloud.google.com/tra Can you add a link to https://cloud.google.com/translate/docs/languages to clarify the spec? I believe this is the one used here... jzw1 2017/04/27 04:54:02 Done. Show quoted text On 2017/04/26 08:40:57, Hiroshi Ichikawa wrote: > Can you add a link to https://cloud.google.com/translate/docs/languages to > clarify the spec? I believe this is the one used here... Done.
	18 @property(nonatomic, copy, readonly) NSString* languageCode;

	19

	20 // The language name in the current OS locale.
	Eugene But (OOO till 7-30) 2017/04/26 20:15:31 How about "Localized language name"? How about "Localized language name"? jzw1 2017/04/27 04:54:02 Done. Show quoted text On 2017/04/26 20:15:31, Eugene But wrote: > How about "Localized language name"? Done. Eugene But (OOO till 7-30) 2017/04/27 13:08:08 I think "The language name in the current OS local Show quoted text On 2017/04/27 04:54:02, jzw1 wrote: > On 2017/04/26 20:15:31, Eugene But wrote: > > How about "Localized language name"? > > Done. I think "The language name in the current OS locale." means a different thing that "Localized language name". Locale is not a language. I suggested "Localized language name" to follow NSLocalizedString naming pattern. jzw1 2017/04/28 02:34:53 I think what you are saying is you prefer localize Show quoted text On 2017/04/27 13:08:08, Eugene But wrote: > On 2017/04/27 04:54:02, jzw1 wrote: > > On 2017/04/26 20:15:31, Eugene But wrote: > > > How about "Localized language name"? > > > > Done. > I think "The language name in the current OS locale." means a different thing > that "Localized language name". Locale is not a language. I suggested "Localized > language name" to follow NSLocalizedString naming pattern. I think what you are saying is you prefer localizedLanguageName over localizedName, yes? Hiroshi Ichikawa 2017/04/28 02:49:51 I believe Eugene is talking about the comment, not Show quoted text On 2017/04/28 02:34:53, jzw1 wrote: > On 2017/04/27 13:08:08, Eugene But wrote: > > On 2017/04/27 04:54:02, jzw1 wrote: > > > On 2017/04/26 20:15:31, Eugene But wrote: > > > > How about "Localized language name"? > > > > > > Done. > > I think "The language name in the current OS locale." means a different thing > > that "Localized language name". Locale is not a language. I suggested > "Localized > > language name" to follow NSLocalizedString naming pattern. > > I think what you are saying is you prefer localizedLanguageName over > localizedName, yes? I believe Eugene is talking about the comment, not the property name. His suggestion is to write "Localized language name" instead of "The language name in the current OS locale.". Eugene But (OOO till 7-30) 2017/04/28 03:07:28 No. My comment is related to "The language name in Show quoted text On 2017/04/28 02:34:53, jzw1 wrote: > On 2017/04/27 13:08:08, Eugene But wrote: > > On 2017/04/27 04:54:02, jzw1 wrote: > > > On 2017/04/26 20:15:31, Eugene But wrote: > > > > How about "Localized language name"? > > > > > > Done. > > I think "The language name in the current OS locale." means a different thing > > that "Localized language name". Locale is not a language. I suggested > "Localized > > language name" to follow NSLocalizedString naming pattern. > > I think what you are saying is you prefer localizedLanguageName over > localizedName, yes? No. My comment is related to "The language name in the current OS locale.". Old and new method names look good to me. jzw1 2017/04/28 05:43:35 ahh ok sorry for understanding. ill update the com Show quoted text On 2017/04/28 03:07:28, Eugene But wrote: > On 2017/04/28 02:34:53, jzw1 wrote: > > On 2017/04/27 13:08:08, Eugene But wrote: > > > On 2017/04/27 04:54:02, jzw1 wrote: > > > > On 2017/04/26 20:15:31, Eugene But wrote: > > > > > How about "Localized language name"? > > > > > > > > Done. > > > I think "The language name in the current OS locale." means a different > thing > > > that "Localized language name". Locale is not a language. I suggested > > "Localized > > > language name" to follow NSLocalizedString naming pattern. > > > > I think what you are saying is you prefer localizedLanguageName over > > localizedName, yes? > No. My comment is related to "The language name in the current OS locale.". Old > and new method names look good to me. ahh ok sorry for understanding. ill update the comment and use the old name.
	21 @property(nonatomic, copy, readonly) NSString* languageName;

	22

	23 @end

	24

	25 #endif // IOS_WEB_VIEW_PUBLIC_CWV_TRANSLATION_LANGUAGE_H

OLD	NEW