ios/web_view/public/cwv_language_detection_result.h - Issue 2839093002: Implemented new Translate API for purely Objective-C clients.

Side by Side Diff: ios/web_view/public/cwv_language_detection_result.h

Issue 2839093002: Implemented new Translate API for purely Objective-C clients. (Closed)

Patch Set: addressed final comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ios/web_view/internal/translate/web_view_translate_client.h ('K') | « ios/web_view/public/ChromeWebView.h ('k') | ios/web_view/public/cwv_translate_delegate.h » ('j') | ios/web_view/public/cwv_translation_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_LANGUAGE_DETECTION_RESULT_H

	6 #define IOS_WEB_VIEW_PUBLIC_CWV_LANGUAGE_DETECTION_RESULT_H

	7

	8 #import <ChromeWebView/cwv_export.h>

	9 #import <Foundation/Foundation.h>

	10

	11 NS_ASSUME_NONNULL_BEGIN

	12

	13 @class CWVTranslationLanguage;

	14

	15 // Encapsulates the results of language detection in one class.

	16 CWV_EXPORT

	17 @interface CWVLanguageDetectionResult : NSObject

	18

	19 - (instancetype)init NS_UNAVAILABLE;

	20

	21 // The detected language of the page.

	22 // Can be used to translate to \|suggestedTargetLanguage\|.
	michaeldo 2017/05/01 18:25:37 No need for second line of comment. No need for second line of comment. jzw1 2017/05/08 03:36:28 Done. Show quoted text On 2017/05/01 18:25:37, michaeldo wrote: > No need for second line of comment. Done.
	23 @property(nonatomic, readonly) CWVTranslationLanguage* pageLanguage;

	24

	25 // The suggested language to translate to.
	michaeldo 2017/05/01 18:25:37 What about this specifying where this comes from. What about this specifying where this comes from. For example: The suggested target translation language based on the user's device language. Please feel free to be more specific though, I didn't check where this value is filled in from. jzw1 2017/05/08 03:36:28 I believe Eugene didn't want to be too specific si Show quoted text On 2017/05/01 18:25:37, michaeldo wrote: > What about this specifying where this comes from. For example: > > The suggested target translation language based on the user's device language. > > Please feel free to be more specific though, I didn't check where this value is > filled in from. I believe Eugene didn't want to be too specific since this can change according to preferences. michaeldo 2017/05/08 15:15:48 Ok, no prob. That's a good point. Show quoted text On 2017/05/08 03:36:28, jzw1 wrote: > On 2017/05/01 18:25:37, michaeldo wrote: > > What about this specifying where this comes from. For example: > > > > The suggested target translation language based on the user's device language. > > > > Please feel free to be more specific though, I didn't check where this value > is > > filled in from. > > I believe Eugene didn't want to be too specific since this can change according > to preferences. Ok, no prob. That's a good point.
	26 // Can be used to translate from \|detectedPageLanguage\|.
	michaeldo 2017/05/01 18:25:37 No need for second line of comment. No need for second line of comment. jzw1 2017/05/08 03:36:28 Done. Show quoted text On 2017/05/01 18:25:37, michaeldo wrote: > No need for second line of comment. Done.
	27 @property(nonatomic, readonly) CWVTranslationLanguage* suggestedTargetLanguage;

	28

	29 // The list of supported languages that can be used in translation.

	30 @property(nonatomic, readonly)
	michaeldo 2017/05/01 18:25:37 copy attribute here? copy attribute here? jzw1 2017/05/08 03:36:28 Done. Show quoted text On 2017/05/01 18:25:37, michaeldo wrote: > copy attribute here? Done.
	31 NSArray<CWVTranslationLanguage> supportedLanguages;

	32

	33 @end

	34

	35 NS_ASSUME_NONNULL_END

	36

	37 #endif // IOS_WEB_VIEW_PUBLIC_CWV_LANGUAGE_DETECTION_RESULT_H

OLD	NEW