Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2839063004: [Autofill] UKM for suggestions polled field. (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 61d7f85e60b1bda2204ebb5fa6cd69745b4dfc5b..974f0cbf7f9653f1fb9722b003afd49aeb3c031e 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -36,8 +36,12 @@ extern const char kUKMIsForCreditCardMetricName[];
extern const char kUKMLocalRecordTypeCountMetricName[];
extern const char kUKMServerRecordTypeCountMetricName[];
-// |UkmEntry| when we show suggestions.
+// |UkmEntry| when we show suggestions and when user edits text field. See
+// |kUkmTextFieldDidChangeEntryName|.
extern const char kUKMSuggestionsShownEntryName[];
+extern const char kUKMHeuristicTypeMetricName[];
+extern const char kUKMHtmlFieldTypeMetricName[];
+extern const char kUKMServerTypeMetricName[];
// |UkmEntry| when user selects a masked server credit card.
extern const char kUKMSelectedMaskedServerCardEntryName[];
@@ -57,9 +61,6 @@ extern const char kUKMRecordTypeMetricName[];
// |UkmEntry| for user editing text field. Metrics contain field's attributes.
extern const char kUKMTextFieldDidChangeEntryName[];
extern const char kUKMFieldTypeGroupMetricName[];
-extern const char kUKMHeuristicTypeMetricName[];
-extern const char kUKMServerTypeMetricName[];
-extern const char kUKMHtmlFieldTypeMetricName[];
extern const char kUKMHtmlFieldModeMetricName[];
extern const char kUKMIsAutofilledMetricName[];
extern const char kUKMIsEmptyMetricName[];
@@ -629,7 +630,7 @@ class AutofillMetrics {
void LogInteractedWithForm(bool is_for_credit_card,
size_t local_record_type_count,
size_t server_record_type_count);
- void LogSuggestionsShown();
+ void LogSuggestionsShown(const AutofillField& field);
void LogSelectedMaskedServerCard();
void LogDidFillSuggestion(int record_type);
void LogTextFieldDidChange(const AutofillField& field);
@@ -859,7 +860,7 @@ class AutofillMetrics {
void OnDidPollSuggestions(const FormFieldData& field);
- void OnDidShowSuggestions();
+ void OnDidShowSuggestions(const AutofillField& field);
void OnDidSelectMaskedServerCardSuggestion();
« no previous file with comments | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/autofill_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698