Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2501)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2839063004: [Autofill] UKM for suggestions polled field. (Closed)
Patch Set: Added ukm.xml and resolved conflict Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 61d7f85e60b1bda2204ebb5fa6cd69745b4dfc5b..87dc575aa1497ca54ca5e6f3136a3231cd7b0c6b 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -38,6 +38,9 @@ extern const char kUKMServerRecordTypeCountMetricName[];
// |UkmEntry| when we show suggestions.
csashi 2017/05/25 08:40:33 and when user edits text field. See |kUkmTextField
jiahuiguo 2017/05/25 19:02:35 Done.
extern const char kUKMSuggestionsShownEntryName[];
+extern const char kUKMHeuristicTypeMetricName[];
+extern const char kUKMHtmlFieldTypeMetricName[];
+extern const char kUKMServerTypeMetricName[];
// |UkmEntry| when user selects a masked server credit card.
extern const char kUKMSelectedMaskedServerCardEntryName[];
@@ -57,9 +60,6 @@ extern const char kUKMRecordTypeMetricName[];
// |UkmEntry| for user editing text field. Metrics contain field's attributes.
extern const char kUKMTextFieldDidChangeEntryName[];
extern const char kUKMFieldTypeGroupMetricName[];
-extern const char kUKMHeuristicTypeMetricName[];
-extern const char kUKMServerTypeMetricName[];
-extern const char kUKMHtmlFieldTypeMetricName[];
extern const char kUKMHtmlFieldModeMetricName[];
extern const char kUKMIsAutofilledMetricName[];
extern const char kUKMIsEmptyMetricName[];
@@ -629,7 +629,7 @@ class AutofillMetrics {
void LogInteractedWithForm(bool is_for_credit_card,
size_t local_record_type_count,
size_t server_record_type_count);
- void LogSuggestionsShown();
+ void LogSuggestionsShown(const AutofillField& field);
void LogSelectedMaskedServerCard();
void LogDidFillSuggestion(int record_type);
void LogTextFieldDidChange(const AutofillField& field);
@@ -859,7 +859,7 @@ class AutofillMetrics {
void OnDidPollSuggestions(const FormFieldData& field);
- void OnDidShowSuggestions();
+ void OnDidShowSuggestions(const AutofillField& field);
void OnDidSelectMaskedServerCardSuggestion();

Powered by Google App Engine
This is Rietveld 408576698