Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 2839063004: [Autofill] UKM for suggestions polled field. (Closed)
Patch Set: Change to suggestionShown Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 FormStructure** updated_form) WARN_UNUSED_RESULT; 404 FormStructure** updated_form) WARN_UNUSED_RESULT;
405 405
406 // Returns a list of values from the stored profiles that match |type| and the 406 // Returns a list of values from the stored profiles that match |type| and the
407 // value of |field| and returns the labels of the matching profiles. |labels| 407 // value of |field| and returns the labels of the matching profiles. |labels|
408 // is filled with the Profile label. 408 // is filled with the Profile label.
409 std::vector<Suggestion> GetProfileSuggestions( 409 std::vector<Suggestion> GetProfileSuggestions(
410 const FormStructure& form, 410 const FormStructure& form,
411 const FormFieldData& field, 411 const FormFieldData& field,
412 const AutofillField& autofill_field) const; 412 const AutofillField& autofill_field) const;
413 413
414 // Returns a list of values from the stored credit cards that match |type| and 414 // Returns a list of values from the stored credit cards that match field type
415 // the value of |field| and returns the labels of the matching credit cards. 415 // the value of |field| and returns the labels of the matching credit cards.
Jared Saul 2017/05/24 18:06:35 nit: "match field type the value of |field|" reads
jiahuiguo 2017/05/24 21:27:33 Acknowledged. I just reverted this change, thanks
416 std::vector<Suggestion> GetCreditCardSuggestions( 416 std::vector<Suggestion> GetCreditCardSuggestions(
417 const FormFieldData& field, 417 const FormFieldData& field,
418 const AutofillType& type) const; 418 const AutofillType& type) const;
419 419
420 // Parses the forms using heuristic matching and querying the Autofill server. 420 // Parses the forms using heuristic matching and querying the Autofill server.
421 void ParseForms(const std::vector<FormData>& forms); 421 void ParseForms(const std::vector<FormData>& forms);
422 422
423 // Parses the form and adds it to |form_structures_|. 423 // Parses the form and adds it to |form_structures_|.
424 bool ParseForm(const FormData& form, FormStructure** parsed_form_structure); 424 bool ParseForm(const FormData& form, FormStructure** parsed_form_structure);
425 425
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 656 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
657 OnLoadedServerPredictions_ResetManager); 657 OnLoadedServerPredictions_ResetManager);
658 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard); 658 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
659 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate); 659 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
660 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 660 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
661 }; 661 };
662 662
663 } // namespace autofill 663 } // namespace autofill
664 664
665 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 665 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698