Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

Issue 2839063003: Implement tail processing for AudioNodes (Closed)
Patch Set: Make declaration order consistent Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
index 94a4364a7df6806e1717e8e8065a67a3464b7536..77991b225b56487a65e1a16eea1ef9226fcfc8ac 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
@@ -103,7 +103,7 @@ PannerHandler::~PannerHandler() {
void PannerHandler::Process(size_t frames_to_process) {
AudioBus* destination = Output(0).Bus();
- if (!IsInitialized() || !Input(0).IsConnected() || !panner_.get()) {
+ if (!IsInitialized() || !panner_.get()) {
destination->Zero();
return;
}
@@ -638,6 +638,14 @@ void PannerHandler::UpdateDirtyState() {
PannerHandler::kDistanceConeGainDirty);
}
}
+
+bool PannerHandler::RequiresTailProcessing() const {
+ // If there's no panner set up yet, assume we require tail
+ // processing in case the HRTF panner is set later, which does
+ // require tail processing.
+ return panner_ ? panner_->RequiresTailProcessing() : true;
+}
+
// ----------------------------------------------------------------
PannerNode::PannerNode(BaseAudioContext& context)

Powered by Google App Engine
This is Rietveld 408576698