third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2839063003: Implement tail processing for AudioNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2839063003: Implement tail processing for AudioNodes (Closed)

Patch Set: Make declaration order consistent Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index a9ee5414ee4122ee94c343cb0b9e4ad1d30a6ffb..7f5698ab71d942e92b482136daae6dd27b65ac9f 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -230,12 +230,6 @@ bool AudioBufferSourceHandler::RenderFromBuffer(

grain_offset_ + grain_duration_, buffer_sample_rate)

: buffer_length;

- // This is a HACK to allow for HRTF tail-time - avoids glitch at end.

- // FIXME: implement tailTime for each AudioNode for a more general solution to

- // this problem, https://bugs.webkit.org/show_bug.cgi?id=77224

- if (is_grain_)

- end_frame += 512;

// Do some sanity checking.

if (end_frame > buffer_length)

end_frame = buffer_length;