WebView autofill implementation

components/autofill/content/browser/content_autofill_driver_factory.h

Index: components/autofill/content/browser/content_autofill_driver_factory.h
diff --git a/components/autofill/content/browser/content_autofill_driver_factory.h b/components/autofill/content/browser/content_autofill_driver_factory.h
index 4a1156bb7644c1dd9def067cabcde187a2fca403..e7f0b9789143d129bea779556d4b4d81165a6b03 100644
--- a/components/autofill/content/browser/content_autofill_driver_factory.h
+++ b/components/autofill/content/browser/content_autofill_driver_factory.h
@@ -21,6 +21,7 @@ class RenderFrameHost;
 namespace autofill {
 
 class ContentAutofillDriver;
+class AutofillProvider;
 
 // Manages lifetime of ContentAutofillDriver. One Factory per WebContents
 // creates one Driver per RenderFrame.
@@ -35,6 +36,14 @@ class ContentAutofillDriverFactory : public AutofillDriverFactory,
       AutofillClient* client,
       const std::string& app_locale,
       AutofillManager::AutofillDownloadManagerState enable_download_manager);
+
+  static void CreateForWebContentsAndDelegate(
+      content::WebContents* contents,
+      AutofillClient* client,
+      const std::string& app_locale,
+      AutofillManager::AutofillDownloadManagerState enable_download_manager,
+      AutofillProvider* provider);
+
   static ContentAutofillDriverFactory* FromWebContents(
       content::WebContents* contents);
   static void BindAutofillDriver(
@@ -61,10 +70,12 @@ class ContentAutofillDriverFactory : public AutofillDriverFactory,
       content::WebContents* web_contents,
       AutofillClient* client,
       const std::string& app_locale,
-      AutofillManager::AutofillDownloadManagerState enable_download_manager);
+      AutofillManager::AutofillDownloadManagerState enable_download_manager,
+      AutofillProvider* provider);
 
   std::string app_locale_;
   AutofillManager::AutofillDownloadManagerState enable_download_manager_;
+  AutofillProvider* provider_;

[sebsg, 2017/05/24 13:32:42]

Since this is only used on Android, we could put all of this in an ifdef? That
would lead to duplicate constructor in some classes but I think the result might
be more clear. 

What do you think?

[michaelbai, 2017/05/24 16:45:28]

I have different opinion for this.
- We should avoid os specific ifdef, shouldn't we? 
- The code actually become more complicated once we write two constructors
because they always need to share some code,  ContentAutofillDriver is good
example, we need to add InitAutofillManager() method for common code, the code
will become more complete from my aspect; further more, in the future, we would
have to test the patch in different platforms.
- AutofillProvider is almost an interface, it has little impact on binary size.
- I noticed we ifdef AutofillAssistant, it tells AutofillAssistant is only used
in Android and iOS, we could add comment in AutofillContentDriver to get same
effect.
  

[sebsg, 2017/05/25 20:57:36]

sure, that's fair.

[michaelbai, 2017/05/26 23:12:08]

Thanks

 };
 
 }  // namespace autofill