Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Unified Diff: components/autofill/core/browser/form_field_data_android.cc

Issue 2839023003: WebView autofill implementation (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_field_data_android.cc
diff --git a/components/autofill/core/browser/form_field_data_android.cc b/components/autofill/core/browser/form_field_data_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..57f4d165185a41ba39a46a3ec5984b7fd795a861
--- /dev/null
+++ b/components/autofill/core/browser/form_field_data_android.cc
@@ -0,0 +1,81 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/form_field_data_android.h"
+
+#include "base/android/jni_string.h"
+#include "content/public/browser/browser_thread.h"
+#include "jni/FormFieldData_jni.h"
+
+using base::android::AttachCurrentThread;
+using base::android::ConvertJavaStringToUTF16;
+using base::android::ConvertUTF16ToJavaString;
+using base::android::ConvertUTF8ToJavaString;
+using base::android::JavaParamRef;
+using base::android::JavaRef;
+using base::android::ScopedJavaGlobalRef;
+using base::android::ScopedJavaLocalRef;
+using content::BrowserThread;
+
+namespace autofill {
+
+FormFieldDataAndroid::FormFieldDataAndroid(FormFieldData* field)
+ : field_ptr_(field) {}
+
+ScopedJavaLocalRef<jobject> FormFieldDataAndroid::GetJavaPeer() {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+ if (obj.is_null()) {
+ ScopedJavaLocalRef<jstring> jname =
+ ConvertUTF16ToJavaString(env, field_ptr_->name);
+ ScopedJavaLocalRef<jstring> jlabel =
+ ConvertUTF16ToJavaString(env, field_ptr_->label);
+ ScopedJavaLocalRef<jstring> jvalue =
+ ConvertUTF16ToJavaString(env, field_ptr_->value);
+ ScopedJavaLocalRef<jstring> jautocompleteAttr =
+ ConvertUTF8ToJavaString(env, field_ptr_->autocomplete_attribute);
+ ScopedJavaLocalRef<jstring> jplaceholder =
+ ConvertUTF16ToJavaString(env, field_ptr_->placeholder);
+ ScopedJavaLocalRef<jstring> jid =
+ ConvertUTF16ToJavaString(env, field_ptr_->id);
+ ScopedJavaLocalRef<jstring> jtype =
+ ConvertUTF8ToJavaString(env, field_ptr_->form_control_type);
+
+ obj = Java_FormFieldData_createFormFieldData(
+ env, jname, jlabel, jvalue, jautocompleteAttr,
+ field_ptr_->should_autocomplete, jplaceholder, jtype, jid);
+ java_ref_ = JavaObjectWeakGlobalRef(env, obj);
+ }
+ return obj;
+}
+
+void FormFieldDataAndroid::PullAutofillValue() {
sgurun-gerrit only 2017/04/28 01:46:40 make names match with java, i.e. getValue?
michaelbai 2017/05/03 04:43:59 Done.
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ JNIEnv* env = AttachCurrentThread();
+
+ ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+ if (obj.is_null())
+ return;
+ ScopedJavaLocalRef<jstring> jvalue = Java_FormFieldData_getValue(env, obj);
+ if (jvalue.is_null())
+ return;
+ field_ptr_->value = ConvertJavaStringToUTF16(env, jvalue);
+ field_ptr_->is_autofilled = true;
+}
+
+void FormFieldDataAndroid::OnTextFieldDidChange(const base::string16& value) {
+ field_ptr_->value = value;
+ field_ptr_->is_autofilled = false;
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
sgurun-gerrit only 2017/04/28 01:46:40 nit: move dcheck ahead
michaelbai 2017/05/03 04:43:59 Done.
+ JNIEnv* env = AttachCurrentThread();
+ ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+ if (obj.is_null())
+ return;
+
+ Java_FormFieldData_updataValue(env, obj,
sgurun-gerrit only 2017/04/28 01:46:40 nit: s/updata/update/
michaelbai 2017/05/03 04:43:59 Done.
+ ConvertUTF16ToJavaString(env, value));
+}
+
+} // namespace autofil

Powered by Google App Engine
This is Rietveld 408576698