android_webview/java/src/org/chromium/android_webview/AwSettings.java - Issue 2839023003: WebView autofill implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwSettings.java

Issue 2839023003: WebView autofill implementation (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/native/aw_contents.h » ('j') | android_webview/native/aw_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwSettings.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwSettings.java b/android_webview/java/src/org/chromium/android_webview/AwSettings.java

index 9b9a1f36ad9ec34bd2870bd19bca99f9c3760a85..b43c5514f7966ce081a6f0cb9500c7e525d25b28 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwSettings.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwSettings.java

@@ -17,7 +17,6 @@ import android.webkit.WebSettings.LayoutAlgorithm;

import android.webkit.WebSettings.PluginState;

import android.webkit.WebSettings.ZoomDensity;

-import org.chromium.base.BuildInfo;

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

@@ -109,7 +108,7 @@ public class AwSettings {

private int mCacheMode = WebSettings.LOAD_DEFAULT;

private boolean mShouldFocusFirstNode = true;

private boolean mGeolocationEnabled = true;

- private boolean mAutoCompleteEnabled = !BuildInfo.isAtLeastO();

+ private boolean mAutoCompleteEnabled = true;

sgurun-gerrit only 2017/04/27 21:51:44 do not enable autocomplete for O, it will be disab

michaelbai 2017/05/03 04:43:58 Done.

private boolean mFullscreenSupported;

private boolean mSupportZoom = true;

private boolean mBuiltInZoomControls;