WebView autofill implementation

components/autofill/core/common/form_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 #define COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_
 
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "url/gurl.h"
 
 namespace autofill {
 
 // Holds information about a form to be filled and/or submitted.
 struct FormData {
   FormData();
   FormData(const FormData& data);
   ~FormData();
 
   // Returns true if two forms are the same, not counting the values of the
   // form elements.
   bool SameFormAs(const FormData& other) const;
 
+  // Same as SameFormAs() except calling FormFieldData.SimilarFieldAs() to
+  // comparing fields, so we know forms are similar enough to be considered as

[sebsg, 2017/05/08 15:38:17]

comparing -> compare. Also I feel like what's after the coma doesn't add much to
understand what the function does, I would remove it.

[michaelbai, 2017/05/09 00:27:03]

Done.

+  // same for autofill purpose.
+  bool SimilarFormAs(const FormData& other) const;
+
   // Note: operator==() performs a full-field-comparison(byte by byte), this is
   // different from SameFormAs(), which ignores comparison for those "values" of
   // all form fields, just like what FormFieldData::SameFieldAs() ignores.
   bool operator==(const FormData& form) const;
   bool operator!=(const FormData& form) const;
   // Allow FormData to be a key in STL containers.
   bool operator<(const FormData& form) const;
 
   // The name of the form.
   base::string16 name;
@@ skipping 24 matching lines @@
 // cases we need to store C strings without embedded '\0' symbols.
 void SerializeFormDataToBase64String(const FormData& form_data,
                                      std::string* output);
 // Deserialize FormData. Returns true on success.
 bool DeserializeFormDataFromBase64String(const base::StringPiece& input,
                                          FormData* form_data);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_COMMON_FORM_DATA_H_