Issue 2838983002: Fix a pair of issues in the Dart code for the front end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2838983002: Fix a pair of issues in the Dart code for the front end. (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)

Modified:
3 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a pair of issues in the Dart code for the front end. - A type needed for an annotation was not visible. - An iterable was passed instead of a list. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9adfa8a10585d270ed469f149b156a4b83301a95

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/front_end/lib/src/fasta/fasta.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/kernel/lib/binary/ast_to_binary.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

The Iterable/List mismatch didn't fail because all the List needs is length and forEach.

3 years, 7 months ago (2017-04-25 19:39:33 UTC) #2

Kevin Millikin (Google)

3 years, 7 months ago (2017-04-25 19:45:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9adfa8a10585d270ed469f149b156a4b83301a95 (presubmit successful).