Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Issue 2838973002: Fix broken precompiled runtime build. (Closed)

Created:
3 years, 8 months ago by Kevin Millikin (Google)
Modified:
3 years, 8 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken precompiled runtime build. In the precompiled runtime, none of the Kernel AST node classes are defined. Guard the code for reading Kernel programs by an #ifdef. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/71aa457a96a939e347b83b6f5fa50e1f5437f0c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M runtime/bin/main.cc View 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 8 months ago (2017-04-25 19:18:17 UTC) #2
zra
lgtm
3 years, 8 months ago (2017-04-25 19:26:43 UTC) #3
Kevin Millikin (Google)
3 years, 8 months ago (2017-04-25 19:27:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71aa457a96a939e347b83b6f5fa50e1f5437f0c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698