services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc - Issue 2838913002: memory-infra: Add SUMMARY_ONLY MemoryDumpType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

Issue 2838913002: memory-infra: Add SUMMARY_ONLY MemoryDumpType (Closed)

Patch Set: fix for rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/memory_tracing_observer.cc ('k') | services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

index fcf7e6e45c54d8112a269331a3eb2566cf241807..f0458fb8cc6eb6478309987dea249d68bfae2ec9 100644

--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

@@ -22,6 +22,8 @@ EnumTraits<memory_instrumentation::mojom::DumpType,

return memory_instrumentation::mojom::DumpType::EXPLICITLY_TRIGGERED;

case base::trace_event::MemoryDumpType::PEAK_MEMORY_USAGE:

return memory_instrumentation::mojom::DumpType::PEAK_MEMORY_USAGE;

+ case base::trace_event::MemoryDumpType::SUMMARY_ONLY:

+ return memory_instrumentation::mojom::DumpType::SUMMARY_ONLY;

default:

CHECK(false) << "Invalid type: " << static_cast<uint8_t>(type);

// This should not be reached. Just return a random value.

@@ -44,6 +46,9 @@ bool EnumTraits<memory_instrumentation::mojom::DumpType,

case memory_instrumentation::mojom::DumpType::PEAK_MEMORY_USAGE:

*out = base::trace_event::MemoryDumpType::PEAK_MEMORY_USAGE;

break;

+ case memory_instrumentation::mojom::DumpType::SUMMARY_ONLY:

+ *out = base::trace_event::MemoryDumpType::SUMMARY_ONLY;

+ break;

default:

NOTREACHED() << "Invalid type: " << static_cast<uint8_t>(input);

return false;