memory-infra: Add SUMMARY_ONLY MemoryDumpType

base/trace_event/memory_dump_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_dump_manager.h"
 
 #include <inttypes.h>
 #include <stdio.h>
 
 #include <algorithm>
@@ skipping 722 matching lines @@
   // The results struct to fill.
   // TODO(hjd): Transitional until we send the full PMD. See crbug.com/704203
   base::Optional<MemoryDumpCallbackResult> result;
 
   bool dump_successful = pmd_async_state->dump_successful;
 
   for (const auto& kv : pmd_async_state->process_dumps) {
     ProcessId pid = kv.first;  // kNullProcessId for the current process.
     ProcessMemoryDump* process_memory_dump = kv.second.get();
 
-    bool added_to_trace = tracing_observer_->AddDumpToTraceIfEnabled(
-        &pmd_async_state->req_args, pid, process_memory_dump);
+    // Some dumps are requested just to cacluate the summary. These shouldn't

[Primiano Tucci (use gerrit), 2017/04/25 18:02:22]

s/some dumps/SUMMARY_ONLY/
s/just to cacluate the summary/just to return the summarized result in the
MemoryDumpReqCalblback/

[hjd, 2017/04/26 11:11:57]

Done.

+    // be added to the trace to avoid confusing trace consumers.
+    if (pmd_async_state->req_args.dump_type != MemoryDumpType::SUMMARY_ONLY) {
+      bool added_to_trace = tracing_observer_->AddDumpToTraceIfEnabled(
+          &pmd_async_state->req_args, pid, process_memory_dump);
 
-    dump_successful = dump_successful && added_to_trace;
+      dump_successful = dump_successful && added_to_trace;
+    }
 
     // TODO(hjd): Transitional until we send the full PMD. See crbug.com/704203
     // Don't try to fill the struct in detailed mode since it is hard to avoid
     // double counting.
     if (pmd_async_state->req_args.level_of_detail ==
         MemoryDumpLevelOfDetail::DETAILED)
       continue;
     if (!result.has_value())
       result = MemoryDumpCallbackResult();
     // TODO(hjd): Transitional until we send the full PMD. See crbug.com/704203
@@ skipping 175 matching lines @@
   if (iter == process_dumps.end()) {
     std::unique_ptr<ProcessMemoryDump> new_pmd(
         new ProcessMemoryDump(session_state, dump_args));
     iter = process_dumps.insert(std::make_pair(pid, std::move(new_pmd))).first;
   }
   return iter->second.get();
 }
 
 }  // namespace trace_event
 }  // namespace base