base/values.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index f24646cbef6702d9b05e55a91816e1c15ac75717..0d49bc30ab64ea04e97b046029cde77889423f65 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -1083,10 +1083,6 @@ void ListValue::Reserve(size_t n) {

list_->reserve(n);

}

-bool ListValue::Set(size_t index, Value* in_value) {

- return Set(index, WrapUnique(in_value));

bool ListValue::Set(size_t index, std::unique_ptr<Value> in_value) {

if (!in_value)

return false;