Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: extensions/common/extension_l10n_util.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)
Patch Set: Fix Compilation Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_l10n_util.cc
diff --git a/extensions/common/extension_l10n_util.cc b/extensions/common/extension_l10n_util.cc
index 4422ca344d260bc504df2fb0694e71943b11c6b0..ac0ac6415a194e218b78f11bbe160d9aba382f4f 100644
--- a/extensions/common/extension_l10n_util.cc
+++ b/extensions/common/extension_l10n_util.cc
@@ -15,6 +15,7 @@
#include "base/files/file_util.h"
#include "base/json/json_file_value_serializer.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -92,7 +93,7 @@ bool LocalizeManifestListValue(const std::string& key,
std::string result;
if (list->GetString(i, &result)) {
if (messages.ReplaceMessages(&result, error))
- list->Set(i, new base::Value(result));
+ list->Set(i, base::MakeUnique<base::Value>(result));
else
ret = false;
}
« no previous file with comments | « extensions/browser/api/device_permissions_manager.cc ('k') | ios/chrome/browser/notification_promo_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698