Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/policy/core/common/configuration_policy_provider_test.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)
Patch Set: Fix Compilation Error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/configuration_policy_provider_test.cc
diff --git a/components/policy/core/common/configuration_policy_provider_test.cc b/components/policy/core/common/configuration_policy_provider_test.cc
index ad5c2640e45b3305f305aa45364c2df02a856ff0..7b2efa4e2d91f2eb9a11a8a4f6775ebb8a5986eb 100644
--- a/components/policy/core/common/configuration_policy_provider_test.cc
+++ b/components/policy/core/common/configuration_policy_provider_test.cc
@@ -284,8 +284,8 @@ TEST_P(ConfigurationPolicyProviderTest, IntegerValue) {
TEST_P(ConfigurationPolicyProviderTest, StringListValue) {
base::ListValue expected_value;
- expected_value.Set(0U, new base::Value("first"));
- expected_value.Set(1U, new base::Value("second"));
+ expected_value.AppendString("first");
+ expected_value.AppendString("second");
CheckValue(test_keys::kKeyStringList,
expected_value,
base::Bind(&PolicyProviderTestHarness::InstallStringListPolicy,
@@ -302,8 +302,8 @@ TEST_P(ConfigurationPolicyProviderTest, DictionaryValue) {
expected_value.SetString("string", "omg");
base::ListValue* list = new base::ListValue();
- list->Set(0U, new base::Value("first"));
- list->Set(1U, new base::Value("second"));
+ list->AppendString("first");
+ list->AppendString("second");
expected_value.Set("array", list);
base::DictionaryValue* dict = new base::DictionaryValue();
« no previous file with comments | « components/json_schema/json_schema_validator_unittest_base.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698