base/values.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Fix Compilation Error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values.cc

diff --git a/base/values.cc b/base/values.cc

index 3397f1c3450c21c5cd58937c36ce9786cc41fb12..1aab924f04432adeb22c566a53cace4f1b8896e8 100644

--- a/base/values.cc

+++ b/base/values.cc

@@ -1067,10 +1067,6 @@ void ListValue::Reserve(size_t n) {

list_->reserve(n);

}

-bool ListValue::Set(size_t index, Value* in_value) {

- return Set(index, WrapUnique(in_value));

bool ListValue::Set(size_t index, std::unique_ptr<Value> in_value) {

if (!in_value)

return false;

« no previous file with comments | « base/values.h ('k') | chrome/browser/metrics/android_metrics_provider.cc » ('j') | no next file with comments »