Remove base::ListValue::Set(size_t, base::Value*)

ipc/ipc_message_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message_utils.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/nullable_string16.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/unguessable_token.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_attachment.h"
 #include "ipc/ipc_message_attachment_set.h"
@@ skipping 210 matching lines @@
 bool ReadListValue(const base::Pickle* m,
                    base::PickleIterator* iter,
                    base::ListValue* value,
                    int recursion) {
   int size;
   if (!ReadParam(m, iter, &size))
     return false;
 
   for (int i = 0; i < size; ++i) {
     base::Value* subval;
     if (!ReadValue(m, iter, &subval, recursion + 1))

[vabr (Chromium), 2017/04/25 17:13:15]

I suggest fixing ReadValue to take a pointer to unique_ptr<base::Value> instead.
It only has two callsites. By doing that you can also fix the
SetWithoutPathExpansion at the other callsite.

[jdoerrie, 2017/04/26 11:34:37]

Done.

       return false;
-    value->Set(i, subval);
+    value->Set(i, base::WrapUnique(subval));
   }
 
   return true;
 }
 
 bool ReadValue(const base::Pickle* m,
                base::PickleIterator* iter,
                base::Value** value,
                int recursion) {
   if (recursion > kMaxRecursionDepth) {
@@ skipping 974 matching lines @@
   return result;
 }
 
 void ParamTraits<MSG>::Log(const param_type& p, std::string* l) {
   l->append("<MSG>");
 }
 
 #endif  // OS_WIN
 
 }  // namespace IPC