Remove base::ListValue::Set(size_t, base::Value*)

ipc/ipc_message_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_message.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
 
@@ skipping 48 matching lines @@
   EXPECT_EQ(v3, vs16);
 
   // should fail
   EXPECT_FALSE(iter.ReadInt(&vi));
   EXPECT_FALSE(iter.ReadString(&vs));
   EXPECT_FALSE(iter.ReadString16(&vs16));
 }
 
 TEST(IPCMessageTest, ListValue) {
   base::ListValue input;
-  input.Set(0, new base::Value(42.42));
-  input.Set(1, new base::Value("forty"));
-  input.Set(2, base::MakeUnique<base::Value>());
+  input.AppendDouble(42.42);
+  input.AppendString("forty");
+  input.Append(base::MakeUnique<base::Value>());
 
   IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   IPC::WriteParam(&msg, input);
 
   base::ListValue output;
   base::PickleIterator iter(msg);
   EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
 
   EXPECT_TRUE(input.Equals(&output));
 
   // Also test the corrupt case.
   IPC::Message bad_msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   bad_msg.WriteInt(99);
   iter = base::PickleIterator(bad_msg);
   EXPECT_FALSE(IPC::ReadParam(&bad_msg, &iter, &output));
 }
 
 TEST(IPCMessageTest, DictionaryValue) {
   base::DictionaryValue input;
   input.Set("null", base::MakeUnique<base::Value>());
   input.Set("bool", new base::Value(true));
   input.Set("int", new base::Value(42));
   input.SetWithoutPathExpansion("int.with.dot", new base::Value(43));
 
   std::unique_ptr<base::DictionaryValue> subdict(new base::DictionaryValue());
   subdict->Set("str", new base::Value("forty two"));
   subdict->Set("bool", new base::Value(false));
 
   std::unique_ptr<base::ListValue> sublist(new base::ListValue());
-  sublist->Set(0, new base::Value(42.42));
-  sublist->Set(1, new base::Value("forty"));
-  sublist->Set(2, new base::Value("two"));
+  sublist->AppendDouble(42.42);
+  sublist->AppendString("forty");
+  sublist->AppendString("two");
   subdict->Set("list", sublist.release());
 
   input.Set("dict", subdict.release());
 
   IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   IPC::WriteParam(&msg, input);
 
   base::DictionaryValue output;
   base::PickleIterator iter(msg);
   EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
@@ skipping 157 matching lines @@
 /* TODO: handle sync IPCs
 TEST_F(IPCMessageParameterTest, Sync) {
   std::string output;
   TestMsgClassIS message(42, &output);
   EXPECT_TRUE(OnMessageReceived(message));
   EXPECT_TRUE(called_);
   EXPECT_EQ(output, std::string("out"));
 }*/
 
 }  // namespace IPC