Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2566)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java

Issue 2838833005: Move NewTabPage.LogoShownTime metrics recording into LogoBridge (Closed)
Patch Set: Remove state from LoadTimeMetricsRecorder Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/logo_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
index d38337333bab4fe38381f1fccce40f6e2d2b6d16..373ada4acd33aaf6642a85d1837984c56ba02407 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoDelegateImpl.java
@@ -11,8 +11,6 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.ui.base.PageTransition;
-import java.util.concurrent.TimeUnit;
-
import jp.tomorrowkey.android.gifplayer.BaseGifImage;
/**
@@ -24,7 +22,6 @@ public class LogoDelegateImpl implements LogoView.Delegate {
private static final int STATIC_LOGO_SHOWN = 0;
private static final int CTA_IMAGE_SHOWN = 1;
- private static final String LOGO_SHOWN_TIME_UMA_NAME = "NewTabPage.LogoShownTime";
private static final String LOGO_CLICK_UMA_NAME = "NewTabPage.LogoClick";
private static final int STATIC_LOGO_CLICKED = 0;
@@ -38,8 +35,6 @@ public class LogoDelegateImpl implements LogoView.Delegate {
private String mOnLogoClickUrl;
private String mAnimatedLogoUrl;
- private boolean mHasRecordedLoadTime;
-
private boolean mIsDestroyed;
/**
@@ -94,12 +89,6 @@ public class LogoDelegateImpl implements LogoView.Delegate {
if (logo != null) {
RecordHistogram.recordSparseSlowlyHistogram(LOGO_SHOWN_UMA_NAME,
logo.animatedLogoUrl == null ? STATIC_LOGO_SHOWN : CTA_IMAGE_SHOWN);
- if (!mHasRecordedLoadTime) {
- long loadTime = System.currentTimeMillis() - loadTimeStart;
- RecordHistogram.recordMediumTimesHistogram(
- LOGO_SHOWN_TIME_UMA_NAME, loadTime, TimeUnit.MILLISECONDS);
- mHasRecordedLoadTime = true;
- }
}
logoObserver.onLogoAvailable(logo, fromCache);
}
« no previous file with comments | « no previous file | chrome/browser/android/logo_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698