Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2838833003: Introduces snackbar enum, & other snackbar classes on android for translate (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 272f5777a53f6659f16eaf261d6503264cec03da..fcd38c1437ffad0d3ff2d861fc3a6820d62f5a48 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -38,6 +38,11 @@ class TranslateCompactInfoBar extends InfoBar
sourceLanguageCode, targetLanguageCode, languages, codes);
}
+ @CalledByNative
+ private void showSnackbar(int snackbarType, int nativePtr) {
+ // TODO(ramyasharma): Show snackbar.
+ }
+
TranslateCompactInfoBar(String sourceLanguageCode, String targetLanguageCode,
String[] languages, String[] codes) {
super(R.drawable.infobar_translate, null, null);
@@ -141,14 +146,17 @@ class TranslateCompactInfoBar extends InfoBar
case TranslateMenu.ID_OVERFLOW_ALWAYS_TRANSLATE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.ALWAYS_TRANSLATE, true);
+ nativeShowSnackbar(mNativeTranslateInfoBarPtr);
return;
case TranslateMenu.ID_OVERFLOW_NEVER_LANGUAGE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE, true);
+ nativeShowSnackbar(mNativeTranslateInfoBarPtr);
return;
case TranslateMenu.ID_OVERFLOW_NEVER_SITE:
nativeApplyBoolTranslateOption(
mNativeTranslateInfoBarPtr, TranslateOption.NEVER_TRANSLATE_SITE, true);
+ nativeShowSnackbar(mNativeTranslateInfoBarPtr);
return;
case TranslateMenu.ID_OVERFLOW_NOT_THIS_LANGUAGE:
mMenuHelper.show(TranslateMenu.MENU_SOURCE_LANGUAGE);
@@ -186,4 +194,5 @@ class TranslateCompactInfoBar extends InfoBar
long nativeTranslateCompactInfoBar, int option, String value);
private native void nativeApplyBoolTranslateOption(
long nativeTranslateCompactInfoBar, int option, boolean value);
+ private native void nativeShowSnackbar(long nativeTranslateCompactInfoBar);
}

Powered by Google App Engine
This is Rietveld 408576698