chrome/browser/ui/android/infobars/infobar_android.h - Issue 2838833003: Introduces snackbar enum, & other snackbar classes on android for translate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.h

Issue 2838833003: Introduces snackbar enum, & other snackbar classes on android for translate (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/infobars/infobar_android.h

diff --git a/chrome/browser/ui/android/infobars/infobar_android.h b/chrome/browser/ui/android/infobars/infobar_android.h

index b53e1280ab5d70cddb4daea20b0e3af7cf6b7653..272741072466c7c3a7cf87fe507252a3dab9e9f6 100644

--- a/chrome/browser/ui/android/infobars/infobar_android.h

+++ b/chrome/browser/ui/android/infobars/infobar_android.h

@@ -55,7 +55,7 @@ class InfoBarAndroid : public infobars::InfoBar {

void OnCloseButtonClicked(JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj);

- void CloseJavaInfoBar();

+ virtual void CloseJavaInfoBar();

gone 2017/04/26 17:19:51 Yeah, I'm really wary of you overriding this one.

ramyasharma 2017/04/27 08:01:42 Thanks for tips on a different approach. But this

// Maps from a Chromium ID (IDR_TRANSLATE) to a enum value that Java code can

// translate into a Drawable ID using the ResourceId class.