Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4863)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java

Issue 2838833002: 🔍 Introduce default search engine dialog (Closed)
Patch Set: Redo how the dialog is created Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
index cddcab955ddc57c839139abd08d89ec2ab7f22a0..288e5bf35c25a9c619180b4b9cbd46fe58fbc7ea 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/SogouPromoDialog.java
@@ -9,6 +9,7 @@ import android.content.DialogInterface;
import android.content.Intent;
import android.os.Bundle;
import android.support.annotation.IntDef;
+import android.support.annotation.Nullable;
import android.text.SpannableString;
import android.text.method.LinkMovementMethod;
import android.text.style.ClickableSpan;
@@ -45,6 +46,9 @@ public class SogouPromoDialog extends PromoDialog {
private static final int CHOICE_ENUM_COUNT = 4;
+ /** Run when the dialog is dismissed. */
+ private final Runnable mOnDismissedRunnable;
+
private final LocaleManager mLocaleManager;
private final ClickableSpan mSpan = new NoUnderlineClickableSpan() {
@Override
@@ -63,11 +67,13 @@ public class SogouPromoDialog extends PromoDialog {
/**
* Creates an instance of the dialog.
*/
- public SogouPromoDialog(Context context, LocaleManager localeManager) {
+ public SogouPromoDialog(
+ Context context, LocaleManager localeManager, @Nullable Runnable onDismissed) {
super(context);
mLocaleManager = localeManager;
setOnDismissListener(this);
setCanceledOnTouchOutside(false);
+ mOnDismissedRunnable = onDismissed;
}
@Override
@@ -143,5 +149,7 @@ public class SogouPromoDialog extends PromoDialog {
.apply();
RecordHistogram.recordEnumeratedHistogram(
"SpecialLocale.PromotionDialog", mChoice, CHOICE_ENUM_COUNT);
+
+ if (mOnDismissedRunnable != null) mOnDismissedRunnable.run();
}
}

Powered by Google App Engine
This is Rietveld 408576698