Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2838833002: 🔍 Introduce default search engine dialog (Closed)
Patch Set: Redo how the dialog is created Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 93c8ddf012ed647ba947b72fa61655c3fb6b8c77..7ca8f9d255ab476b14823fb08fb2015385dc9ddd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -430,7 +430,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
// LocaleManager can only function after the native library is loaded.
mLocaleManager = LocaleManager.getInstance();
- mLocaleManager.showSearchEnginePromoIfNeeded(this);
+ mLocaleManager.showSearchEnginePromoIfNeeded(this, null);
super.finishNativeInitialization();
} finally {
@@ -665,7 +665,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
// This assumes that the keyboard can not be seen at the same time as the
// newtab button on the toolbar.
getCurrentTabCreator().launchNTP();
- mLocaleManager.showSearchEnginePromoIfNeeded(ChromeTabbedActivity.this);
+ mLocaleManager.showSearchEnginePromoIfNeeded(ChromeTabbedActivity.this, null);
}
};
OnClickListener bookmarkClickHandler = new OnClickListener() {
@@ -881,7 +881,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
mIsOnFirstRun = false;
if (resultCode == RESULT_OK) {
refreshSignIn();
- mLocaleManager.showSearchEnginePromoIfNeeded(this);
+ mLocaleManager.showSearchEnginePromoIfNeeded(this, null);
} else {
if (data != null && data.getBooleanExtra(
FirstRunActivity.RESULT_CLOSE_APP, false)) {
@@ -1390,7 +1390,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
RecordUserAction.record("MobileNewTabOpened");
reportNewTabShortcutUsed(false);
getTabCreator(false).launchUrl(UrlConstants.NTP_URL, TabLaunchType.FROM_CHROME_UI);
- mLocaleManager.showSearchEnginePromoIfNeeded(this);
+ mLocaleManager.showSearchEnginePromoIfNeeded(this, null);
} else if (id == R.id.new_incognito_tab_menu_id) {
if (PrefServiceBridge.getInstance().isIncognitoModeEnabled()) {
getTabModelSelector().getModel(false).commitAllTabClosures();

Powered by Google App Engine
This is Rietveld 408576698