third_party/WebKit/LayoutTests/storage/indexeddb/shared-array-buffer-throws.html - Issue 2838783002: SharedArrayBuffer throws serializing to indexeddb

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/storage/indexeddb/shared-array-buffer-throws.html

Issue 2838783002: SharedArrayBuffer throws serializing to indexeddb (Closed)

Patch Set: forgot README Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/LeakExpectations ('K') | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/storage/indexeddb/README.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>IndexedDB: Attempting to serialize a SharedArrayBuffer should throw</titl e>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6

	7 if (window.SharedArrayBuffer) {

	8 async_test(t => {

	9 const sab = new SharedArrayBuffer('256');
	jbroman 2017/04/25 17:37:23 nit: It's rather weird to pass a string here, give nit: It's rather weird to pass a string here, given that we're just going to convert it to a number. Why not "new SharedArrayBuffer(256)"? binji 2017/04/25 18:06:26 Heh, I noticed this too :) Done. Show quoted text On 2017/04/25 at 17:37:23, jbroman wrote: > nit: It's rather weird to pass a string here, given that we're just going to convert it to a number. Why not "new SharedArrayBuffer(256)"? Heh, I noticed this too :) Done.
	10 const open = indexedDB.open('db');
	jsbell 2017/04/25 00:27:48 I know I gave you the sample code in the bug, but I know I gave you the sample code in the bug, but for the tests, please use the indexeddb_test() helper in: resources/testharness-helpers.js That will ensure the database name is unique to this test case so the test won't fail if copied/pasted, and it cleans up the test before running. it should just be: indexed_db_test( (t, db) => { db.createObjectStore('store'); }, (t, db) => { const sab = new SharedArrayBuffer('256'); const tx = db.transaction('store', 'readwrite'); const store = tx.objectStore('store'); assert_throws("DataCloneError", () => { store.put({sab: sab}, 'key'); }); 'Serializing SharedArrayBuffer throws DataClone error.' ); binji 2017/04/25 17:37:18 Done. Done.
	11 open.onupgradeneeded = t.step_func(e => {

	12 const db = open.result;

	13 db.createObjectStore('store');

	14 });

	15 open.onsuccess = t.step_func_done(e => {

	16 const db = open.result;

	17 const tx = db.transaction('store', 'readwrite');

	18 const store = tx.objectStore('store');

	19

	20 assert_throws("DataCloneError", () => {

	21 store.put({sab: sab}, 'key');

	22 });

	23 });

	24 }, 'Serializing SharedArrayBuffer throws DataClone error.');

	25 } else {

	26 done();
	jbroman 2017/04/25 17:37:23 nit: I don't think you need to explicitly call don nit: I don't think you need to explicitly call done() in this case; it's implied. binji 2017/04/25 18:06:26 Hm, the non-virtual testsuite version hangs when I Show quoted text On 2017/04/25 at 17:37:23, jbroman wrote: > nit: I don't think you need to explicitly call done() in this case; it's implied. Hm, the non-virtual testsuite version hangs when I don't do this. I think it expects at least one test? jbroman 2017/04/25 18:09:42 Acknowledged. Show quoted text On 2017/04/25 at 18:06:26, binji wrote: > On 2017/04/25 at 17:37:23, jbroman wrote: > > nit: I don't think you need to explicitly call done() in this case; it's implied. > > Hm, the non-virtual testsuite version hangs when I don't do this. I think it expects at least one test? Acknowledged.
	27 }

	28

	29 </script>

OLD	NEW