Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2838673005: Do not use inline context for the first float child. (Closed)

Created:
3 years, 8 months ago by Gleb Lanbin
Modified:
3 years, 7 months ago
Reviewers:
ikilpatrick, kojii
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use inline context for the first float child. This patch changes ShouldHandleByInlineContext so it return false if the first child is float. Example(from floats-wrap-top-below-inline-001l.xht): div { float: left; clear: left; } <body> <div style="width: 50px; height: 75px;"></div> <div style="width: 100px; height: 75px;"></div> <span></span> <span></span> </body> The old behavior is that the 1st float will be processed by the inline context. This patch changes that so only floats in the middle of text are processed by the inline context BUG=635619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 6 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
Gleb Lanbin
3 years, 8 months ago (2017-04-25 23:25:09 UTC) #2
Gleb Lanbin
I updated TestExpectations as well,i.e. sorted lines + 3 new tests started failing, but that's ...
3 years, 8 months ago (2017-04-25 23:39:38 UTC) #4
kojii
I think I want to go to the opposite way, to handle all floats/oof in ...
3 years, 8 months ago (2017-04-26 05:33:27 UTC) #11
kojii
In case you missed the conversation, my and Ian's motivations are: 1. The following two ...
3 years, 8 months ago (2017-04-26 06:33:54 UTC) #12
Gleb Lanbin
On 2017/04/26 06:33:54, kojii wrote: > In case you missed the conversation, my and Ian's ...
3 years, 8 months ago (2017-04-26 21:47:25 UTC) #13
kojii
3 years, 8 months ago (2017-04-27 01:16:23 UTC) #14
Great if you can take that over. Disabling tests mean I'm actually requesting
you to fix and re-enable them, so the same meaning to me.

Powered by Google App Engine
This is Rietveld 408576698