third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2838673003: [Devtools][Regression] Fixed websocket frame selection loss on frame received

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2838673003: [Devtools][Regression] Fixed websocket frame selection loss on frame received (Closed)

Patch Set: changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 7e8d4a06d4e88ea0d8a449ab558c212034fcc81e..4ffbd80d304f0241bd3d050c26e130a4dba8a9bf 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -837,7 +837,8 @@ Network.NetworkLogView = class extends UI.VBox {

var request = node.request();

this._timeCalculator.updateBoundaries(request);

this._durationCalculator.updateBoundaries(request);

+ if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut)

+ continue;

node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;

var newParent = this._parentNodeForInsert(node);

var removeFromParent = node.parent && (isFilteredOut || node.parent !== newParent);