Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2838673003: [Devtools][Regression] Fixed websocket frame selection loss on frame received (Closed)
Patch Set: changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 continue; 830 continue;
831 var isFilteredOut = !this._applyFilter(node); 831 var isFilteredOut = !this._applyFilter(node);
832 if (isFilteredOut && node === this._hoveredNode) 832 if (isFilteredOut && node === this._hoveredNode)
833 this._setHoveredNode(null); 833 this._setHoveredNode(null);
834 834
835 if (!isFilteredOut) 835 if (!isFilteredOut)
836 nodesToRefresh.push(node); 836 nodesToRefresh.push(node);
837 var request = node.request(); 837 var request = node.request();
838 this._timeCalculator.updateBoundaries(request); 838 this._timeCalculator.updateBoundaries(request);
839 this._durationCalculator.updateBoundaries(request); 839 this._durationCalculator.updateBoundaries(request);
840 840 if (node[Network.NetworkLogView._isFilteredOutSymbol] === isFilteredOut)
841 continue;
841 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut; 842 node[Network.NetworkLogView._isFilteredOutSymbol] = isFilteredOut;
842 var newParent = this._parentNodeForInsert(node); 843 var newParent = this._parentNodeForInsert(node);
843 var removeFromParent = node.parent && (isFilteredOut || node.parent !== ne wParent); 844 var removeFromParent = node.parent && (isFilteredOut || node.parent !== ne wParent);
844 if (removeFromParent) { 845 if (removeFromParent) {
845 var parent = node.parent; 846 var parent = node.parent;
846 parent.removeChild(node); 847 parent.removeChild(node);
847 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) { 848 while (parent && !parent.hasChildren() && parent.dataGrid && parent.data Grid.rootNode() !== parent) {
848 var grandparent = parent.parent; 849 var grandparent = parent.parent;
849 grandparent.removeChild(parent); 850 grandparent.removeChild(parent);
850 parent = grandparent; 851 parent = grandparent;
(...skipping 988 matching lines...) Expand 10 before | Expand all | Expand 10 after
1839 * @interface 1840 * @interface
1840 */ 1841 */
1841 Network.NetworkRowDecorator = function() {}; 1842 Network.NetworkRowDecorator = function() {};
1842 1843
1843 Network.NetworkRowDecorator.prototype = { 1844 Network.NetworkRowDecorator.prototype = {
1844 /** 1845 /**
1845 * @param {!Network.NetworkNode} node 1846 * @param {!Network.NetworkNode} node
1846 */ 1847 */
1847 decorate(node) {} 1848 decorate(node) {}
1848 }; 1849 };
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/websocket/network-preserve-selection-on-frame-receive-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698