Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2838643003: Invalidate collapsed borders using currentColor when color changes (Closed)
Patch Set: - Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013
8 * Apple Inc. 8 * Apple Inc.
9 * All rights reserved. 9 * All rights reserved.
10 * 10 *
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 if (Section() && Style()->LogicalHeight() != old_style->LogicalHeight()) 65 if (Section() && Style()->LogicalHeight() != old_style->LogicalHeight())
66 Section()->RowLogicalHeightChanged(this); 66 Section()->RowLogicalHeightChanged(this);
67 67
68 if (!Parent()) 68 if (!Parent())
69 return; 69 return;
70 LayoutTable* table = this->Table(); 70 LayoutTable* table = this->Table();
71 if (!table) 71 if (!table)
72 return; 72 return;
73 73
74 if (!table->SelfNeedsLayout() && !table->NormalChildNeedsLayout() && 74 LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(
75 old_style->Border() != Style()->Border()) 75 *this, *table, diff, *old_style);
76 table->InvalidateCollapsedBorders();
77 76
78 if (LayoutTableBoxComponent::DoCellsHaveDirtyWidth(*this, *table, diff, 77 if (LayoutTableBoxComponent::DoCellsHaveDirtyWidth(*this, *table, diff,
79 *old_style)) { 78 *old_style)) {
80 // If the border width changes on a row, we need to make sure the cells in 79 // If the border width changes on a row, we need to make sure the cells in
81 // the row know to lay out again. 80 // the row know to lay out again.
82 // This only happens when borders are collapsed, since they end up affecting 81 // This only happens when borders are collapsed, since they end up affecting
83 // the border sides of the cell itself. 82 // the border sides of the cell itself.
84 for (LayoutBox* child_box = FirstChildBox(); child_box; 83 for (LayoutBox* child_box = FirstChildBox(); child_box;
85 child_box = child_box->NextSiblingBox()) { 84 child_box = child_box->NextSiblingBox()) {
86 if (!child_box->IsTableCell()) 85 if (!child_box->IsTableCell())
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // won't fit but we avoid the complexity of that reading until it 326 // won't fit but we avoid the complexity of that reading until it
328 // is clarified. Tracked by crbug.com/675904 327 // is clarified. Tracked by crbug.com/675904
329 if (RowIndex()) 328 if (RowIndex())
330 return false; 329 return false;
331 LayoutTableSection* header = Table()->Header(); 330 LayoutTableSection* header = Table()->Header();
332 return header && Table()->SectionAbove(Section()) == header && 331 return header && Table()->SectionAbove(Section()) == header &&
333 header->GetPaginationBreakability() != kAllowAnyBreaks; 332 header->GetPaginationBreakability() != kAllowAnyBreaks;
334 } 333 }
335 334
336 } // namespace blink 335 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCol.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698