Invalidate collapsed borders using currentColor when color changes

third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTableBoxComponent.h"
 
 #include "core/layout/LayoutTable.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/style/ComputedStyle.h"
 
 namespace blink {
 
+void LayoutTableBoxComponent::InvalidateCollapsedBordersOnStyleChange(
+    const LayoutObject& table_part,
+    LayoutTable& table,
+    const StyleDifference& diff,
+    const ComputedStyle& old_style) {

[Xianzhu, 2017/04/24 21:09:22]

This doesn't include the !table->SelfNeedsLayout() and similar conditions in
StyleDidChange() methods because
- the conditions were inconsistent;
- the new code is simpler and the extra cost is trivial;
- in the future we can avoid invalidating collapsed borders on layout change,
but only on border style change and NeedsSectionRecalc instead.

+  if (old_style.Border() != table_part.StyleRef().Border() ||
+      (diff.TextDecorationOrColorChanged() &&
+       table_part.StyleRef().HasBorderColorReferencingCurrentColor()))
+    table.InvalidateCollapsedBorders();
+}
+
 bool LayoutTableBoxComponent::DoCellsHaveDirtyWidth(
     const LayoutObject& table_part,
     const LayoutTable& table,
     const StyleDifference& diff,
     const ComputedStyle& old_style) {
   // ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation sets needsFullLayout
   // when border sizes change: checking diff.needsFullLayout() is an
   // optimization, not required for correctness.
   // TODO(dgrogan): Remove tablePart.needsLayout()? Perhaps it was an old
   // optimization but now it seems that diff.needsFullLayout() implies
@@ skipping 18 matching lines @@
   auto& box = static_cast<LayoutTableBoxComponent&>(layout_object_);
   if (box.last_paint_result_ != kFullyPainted &&
       box.last_paint_rect_ != paint_rect)
     layout_object_.SetDisplayItemsUncached();
 
   box.last_paint_result_ = paint_result;
   box.last_paint_rect_ = paint_rect;
 }
 
 }  // namespace blink