Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 2838603004: Re-enable Cloud printers for ChromeOS kiosks. (Closed)
Patch Set: fix indentation Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/print_preview_destination_search_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/search/destination_search.js
diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js
index c9531b014aeff7d0d37cc3891d3c9e10a5e80b7c..33915459b156687deb830e50a3007500cc368a26 100644
--- a/chrome/browser/resources/print_preview/search/destination_search.js
+++ b/chrome/browser/resources/print_preview/search/destination_search.js
@@ -585,9 +585,14 @@ cr.define('print_preview', function() {
*/
onDestinationConfigureRequest_: function(event) {
var destination = event.detail.destination;
- var destinationItem = destination.isLocal ?
- this.localList_.getDestinationItem(destination.id) :
- this.cloudList_.getDestinationItem(destination.id);
+ // Cloud Print Device printers are stored in the local list
+ // crbug.com/713831.
+ // TODO(crbug.com/416701): Upon resolution, update this.
+ var destinationItem =
+ (destination.isLocal ||
+ destination.origin == print_preview.Destination.Origin.DEVICE) ?
+ this.localList_.getDestinationItem(destination.id) :
+ this.cloudList_.getDestinationItem(destination.id);
assert(destinationItem != null,
'User does not select a valid destination item.');
« no previous file with comments | « no previous file | chrome/test/data/webui/print_preview_destination_search_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698